Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package.json syntax error. #43

Closed
MicahZoltu opened this issue Dec 29, 2019 · 1 comment
Closed

Fix package.json syntax error. #43

MicahZoltu opened this issue Dec 29, 2019 · 1 comment

Comments

@MicahZoltu
Copy link

https://github.com/Uniswap/uniswap-v2-core/blob/d2ddbd95e8500cfd3669ab81b64f48956521ea6b/package.json#L3

The proper syntax for this is >=10 not ^10. Currently, this will fail if using NodeJS 12. I would submit a PR, but PRs to private repos are hard... you should make this public.
@NoahZinsmeister
Copy link
Contributor

fixed, works for node@12 now. working on making the repo public :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MicahZoltu @NoahZinsmeister