Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile script to work on Windows. #44

Closed
MicahZoltu opened this issue Dec 29, 2019 · 1 comment
Closed

Fix compile script to work on Windows. #44

MicahZoltu opened this issue Dec 29, 2019 · 1 comment

Comments

@MicahZoltu
Copy link

https://github.com/Uniswap/uniswap-v2-core/blob/d2ddbd95e8500cfd3669ab81b64f48956521ea6b/package.json#L22

rm is not a valid command on Windows. Consider using an NPM module for this instead, or an inline node script with node -e '...'. If you bump the min version of Node supported to v12 (LTS) then you can replace the script line with:

node -e \"require('fs').rmdir('./build/', { recursive: true }, error => { if (error !== null) console.error(error) })\" && waffle waffle.json

(could be simplified if you drop the error logging)

@NoahZinsmeister
Copy link
Contributor

fixed! uses rimraf now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants