Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeripheryPayments contract allows any intermediately called contract to reenter and unwrap WETH/sweep tokens #24

Open
moodysalem opened this issue Mar 10, 2021 · 0 comments
Open

PeripheryPayments contract allows any intermediately called contract to reenter and unwrap WETH/sweep tokens #24

moodysalem opened this issue Mar 10, 2021 · 0 comments
Labels
documentation Improvements or additions to documentation p1 nice to have, not blocking launch

Comments

@moodysalem
Copy link
Contributor

moodysalem commented Mar 10, 2021 •
edited

The PeripheryPayments contract allows any intermediately called untrusted contract (e.g. an ERC777 token gets transferred) to call back into the SwapRouter or NFT contract, taking up to the difference between the current balance of WETH9/WETH10 token and the minimum amount expected by the multicall user
@moodysalem moodysalem added the documentation Improvements or additions to documentation label Mar 10, 2021
@moodysalem moodysalem added the p1 nice to have, not blocking launch label Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation p1 nice to have, not blocking launch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moodysalem and others