Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shall we add BinaryPrefix here? #26

Closed
keilw opened this issue Jan 26, 2018 · 1 comment
Closed

Shall we add BinaryPrefix here? #26

keilw opened this issue Jan 26, 2018 · 1 comment
Assignees
@keilw
Labels
question
Milestone
2.0

Comments

@keilw
Copy link
Member

keilw commented Jan 26, 2018 •
edited
Loading

Currently to reuse it across different implementations, BinaryPrefix resides in uom-lib-common. While Indriya is likely to use much of that library also in 2.0 we could move BinaryPrefix to the unit package next to MetricPrefix, too.
@keilw keilw added the question label Jan 26, 2018
@keilw keilw added this to the 2.0 milestone Jan 26, 2018
@keilw keilw changed the title Do we want to add BinaryPrefix here? Shall we add BinaryPrefix here? Feb 2, 2018
@keilw keilw mentioned this issue Feb 2, 2018
Closed
@keilw keilw added the to do label Mar 6, 2018
@keilw
Copy link
Member Author

keilw commented Mar 24, 2018 •
edited
Loading

It makes sense because the way Prefix is defined in the SPI exposes a UnitConverter and it requires an implementation in the same module. Doing so in uom-lib-common would require workarounds or defining stuff default, so moving it to the RI seems better.

@keilw keilw self-assigned this Mar 24, 2018
@keilw keilw added in progress and removed to do labels Mar 24, 2018
@keilw keilw closed this as completed Mar 25, 2018
@keilw keilw removed the in progress label Mar 25, 2018
@keilw keilw mentioned this issue Mar 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keilw keilw

Labels
question
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@keilw