-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ParserException to MeasurementParseException #46
Comments
Removed usage of ParserException from a format() method, so I would leave it for now, and close this one. Leaving #58 open. |
Reopened this as it would be cleaner and more consistent with JSR 310, 354 and others. The idea would be to leave Please vote on either: |
A) Rename |
B) Keep |
Why not MeasureParseException (makes more sense and shorter) ? |
But this exception can also occur while parsing |
Yes, but |
Although it is only an SPI element of Indriya, we have a |
A rather generic
ParserException
can be found at least in JDK Nashorn, but otherwise both the JDK and other JSRs either call itParseException
(likejava.text.ParseException
) or*ParseException
(likeMonetaryParseException
,DateTimeParseException
, etc.)It is not the most urgent case, but with other proposals like #39 that also would require adding a new name and deprecate the old one, it's worth do mention this as well. A new exception could be called
MeasurementParseException
.The text was updated successfully, but these errors were encountered: