Fixed README section on tests and did some more testing in test_records #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can open up a issue for the tests if you would like to. |
|
There's a bunch of stuff I'll be addressing in records.py so I'll see how it looks in a week or two when my leave finishes . I may rewrite test_records.py as I know more than I did when I started it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README section on testing was seriously wrong. I also attempted (and failed) to fix a problem where
test_records.pywon't run the tests if called on its own. It does run the tests if you usediscovery. Not sure if it's worth opening an issue on it, but if you do assign it to me.