Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data exclude /(iPod|iPhone|iPad|Android)/ not working #38

Closed
AdaptCharm opened this issue Jun 3, 2019 · 9 comments
Closed

Data exclude /(iPod|iPhone|iPad|Android)/ not working #38

AdaptCharm opened this issue Jun 3, 2019 · 9 comments
Labels
bug Something isn't working
Projects

Comments

@AdaptCharm
Copy link

AdaptCharm commented Jun 3, 2019

For some reason the /(iPod|iPhone|iPad|Android)/ data exclude won't work. On desktop in looks fine, however, on mobile phones it looks weird as hell.

My website: https://casinoxbonuses.com/

@JB1905 JB1905 added the bug Something isn't working label Jun 3, 2019
@JB1905
Copy link
Collaborator

JB1905 commented Jun 3, 2019

Hi!
I know where the problem is and I will try to fix it tomorrow.
I need to add additional checks for navigator user agent.

@AdaptCharm
Copy link
Author

Hi!
I know where the problem is and I will try to fix it tomorrow.
I need to add additional checks for navigator user agent.

Hi, did you fix the issues yet?

Thanks in advance.

@JB1905
Copy link
Collaborator

JB1905 commented Jun 4, 2019

Hi!
Update will be available later today or tomorrow.

@JB1905
Copy link
Collaborator

JB1905 commented Jun 4, 2019

v2.0.5 (v2.0.4) probably fixes this bug

@AdaptCharm
Copy link
Author

AdaptCharm commented Jun 4, 2019

v2.0.5 (v2.0.4) probably fixes this bug

The bug on mobile devices is fixed, however, there is a new bug. If you navigate once again to my site https://casinoxbonuses.com/ you'll see that the boxes won't follow your mouse on hover. It just zooms in and out, no tilt effect. This happens only on desktop.

@JB1905
Copy link
Collaborator

JB1905 commented Jun 4, 2019

I added an external library (platform). If you use npm or yarn it is installed automatically. If you use CDN, you must add the script https://cdn.jsdelivr.net/npm/platform@1.3.5/platform.min.js before attaching universal-tilt.js. I will try to solve this better in the next updates.

@AdaptCharm
Copy link
Author

I added an external library (platform). If you use npm or yarn it is installed automatically. If you use CDN, you must add the script https://cdn.jsdelivr.net/npm/platform@1.3.5/platform.min.js before attaching universal-tilt.js. I will try to solve this better in the next updates.

For some reason that lib wouldn't be included through CDN. Any possibility you can permanently fix this without including that library?

@TemaSM
Copy link

TemaSM commented Jun 14, 2019

@JB1905

v2.0.5 (v2.0.4) probably fixes this bug

Btw it probably produces a bug, when base option is set. With 2.0.3 and base works just fine.
image
Problem is here:
image

@JB1905
Copy link
Collaborator

JB1905 commented Jun 16, 2019

Tomorrow I will release new version with built-in platform library

@JB1905 JB1905 closed this as completed Aug 10, 2019
@JB1905 JB1905 reopened this Nov 1, 2021
@JB1905 JB1905 added this to Done in Next Nov 1, 2021
@JB1905 JB1905 closed this as completed Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Next
  
Done
Development

No branches or pull requests

3 participants