Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the super-resolution #14

Closed
jihoontack opened this issue Sep 21, 2021 · 2 comments
Closed

Question about the super-resolution #14

jihoontack opened this issue Sep 21, 2021 · 2 comments

Comments

@jihoontack
Copy link

Hi Ivan,

Thank you for the wonderful research!
Really enjoyed reading your paper (also, the recent ICCV paper was great!)

While I was reading the paper, I recognize the details for the super-resolution (SR) experiments are somewhat missing.
For me SR was not trivial in INR-GAN as it utilizes MultiScale-INR.
If possible could you share the details of SR experiments? e.g., increasing the resolution of the first input grid...?

If you can share the implementation of SR, it couldn't be better!

Hope you have a nice day,
Jihoon

@universome
Copy link
Owner

Hi, Jihoon! In the original paper, we did the upsampling after the first multi-scale block, but as far as I remember, this choice was quite arbitrary and the model performed more-or-less the same regardless of the block idx you choose to do the upsampling in.

In the current implementation, the superresolution is not implemented, I will take a look at it next week. I believe the most reasonable place to incorporate it is before the first block, i.e. in the CoordsInput layer. But this would require to change some misc.assert_shape(...) statements and interpolate static positional embeddings to match the required image size (otherwise, it will fail here).

@jihoontack
Copy link
Author

Thank you so much for the detailed response and the clarification!

Best,
Jihoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants