Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0 installs files back into the build directory #7

Open
yurivict opened this issue Dec 29, 2022 · 4 comments
Open

1.2.0 installs files back into the build directory #7

yurivict opened this issue Dec 29, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@yurivict
Copy link

yurivict commented Dec 29, 2022

Describe the bug
It installs these files:

data/obs-plugins/scrab/locale/en-US.ini
obs-plugins/64bit/scrab.so
/usr/ports/multimedia/obs-scrab/work/.build/rundir/Release/data/obs-plugins/scrab/data/locale/en-US.ini
/usr/ports/multimedia/obs-scrab/work/.build/rundir/Release/obs-plugins/64bit/scrab.so
@dir /usr/ports/multimedia/obs-scrab/work/.build/rundir/Release/data/obs-plugins/scrab/data/locale
@dir /usr/ports/multimedia/obs-scrab/work/.build/rundir/Release/data/obs-plugins/scrab/data
@dir /usr/ports/multimedia/obs-scrab/work/.build/rundir/Release/data/obs-plugins/scrab
@dir /usr/ports/multimedia/obs-scrab/work/.build/rundir/Release/data/obs-plugins
@dir /usr/ports/multimedia/obs-scrab/work/.build/rundir/Release/data
@dir /usr/ports/multimedia/obs-scrab/work/.build/rundir/Release/obs-plugins/64bit
@dir /usr/ports/multimedia/obs-scrab/work/.build/rundir/Release/obs-plugins
@dir /usr/ports/multimedia/obs-scrab/work/.build/rundir/Release
@dir /usr/ports/multimedia/obs-scrab/work/.build/rundir
@dir /usr/ports/multimedia/obs-scrab/work/.build
@dir /usr/ports/multimedia/obs-scrab/work
@dir /usr/ports/multimedia/obs-scrab
@dir /usr/ports/multimedia
@dir /usr/ports

To Reproduce
Regular build + install into a stage directory.

FreeBSD 13.1 STABLE

@yurivict yurivict added the bug Something isn't working label Dec 29, 2022
@univrsal
Copy link
Owner

Idk, works for me, probably only an issue on bsd, which isn't officially supported. You can enable LOCAL_INSTALLATION which should copy the files into ~/.config/obs-studio/plugins/scrab

@yurivict
Copy link
Author

Now I see that it installs files even during the build phase, which is clearly a bug.

make ends with:

-- Installing: /usr/ports/multimedia/obs-scrab/work/stage/usr/ports/multimedia/obs-scrab/work/.build/rundir/Release/lib/obs-plugins/scrab.so
-- Installing: /usr/ports/multimedia/obs-scrab/work/stage/usr/ports/multimedia/obs-scrab/work/.build/rundir/Release/share/obs/obs-plugins/scrab/data
-- Installing: /usr/ports/multimedia/obs-scrab/work/stage/usr/ports/multimedia/obs-scrab/work/.build/rundir/Release/share/obs/obs-plugins/scrab/data/locale
-- Installing: /usr/ports/multimedia/obs-scrab/work/stage/usr/ports/multimedia/obs-scrab/work/.build/rundir/Release/share/obs/obs-plugins/scrab/data/locale/en-US.ini

Only make install should install files.

The only thing that you need to do to install is to add 2 install instructions in cmake.

@univrsal
Copy link
Owner

Does the plugin template also install files into the build directory?
https://github.com/obsproject/obs-plugintemplate

@yurivict
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants