Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect default config in types #41

Closed
itpropro opened this issue Nov 5, 2022 · 0 comments · Fixed by #161
Closed

Reflect default config in types #41

itpropro opened this issue Nov 5, 2022 · 0 comments · Fixed by #161
Labels
bug Something isn't working

Comments

@itpropro
Copy link
Member

itpropro commented Nov 5, 2022

I think ResolvedConfig should not be possibly null, if a default config is present. This would make typings more intuitive, as I have to either cast or do something like this currently:

export const config = (await loadConfig<CustomConfig>({ name: 'myapp', cwd: '../', defaults })).config || defaults
@pi0 pi0 added the bug Something isn't working label Jun 11, 2024
@pi0 pi0 closed this as completed in #161 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants