Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support including handles of contributors #63

Closed
1 task done
danielroe opened this issue Feb 17, 2023 · 3 comments
Closed
1 task done

support including handles of contributors #63

danielroe opened this issue Feb 17, 2023 · 3 comments

Comments

@danielroe
Copy link
Member

Describe the feature

GitHub Releases marks contributors to releases by usage of @ handle. It would be nice to generate these in the contributors list at the bottom (maybe instead of email addresses) so they show up when the release is published.

Additional information

  • Would you be willing to help implement this feature?
@dnldsht
Copy link
Contributor

dnldsht commented Feb 17, 2023

Hi @danielroe, it is supposed to work like that but the service that retrive github usernames from email address has changed.

In pull request #55 I've fixed that, you can merge this commit or I can make a PR that only fix that.

@pi0
Copy link
Member

pi0 commented Feb 17, 2023

Another note that, it works only if commit email matches a public account's email.

@pi0
Copy link
Member

pi0 commented Feb 17, 2023

Thanks for the notice @dnldsht. I have added backward compatibility route to ungh until updating changlogen (unjs/ungh@6178c4a) (https://ungh.cc/users/find/pooya@pi0.io)

@pi0 pi0 closed this as completed in a5ab510 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants