fix: accept ipv6 as valid hostname

unjs · Sep 7, 2023 · d537a51 · d537a51
1 parent 9dccfd9
commit d537a51
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/_internal.ts b/src/_internal.ts
@@ -81,7 +81,7 @@ export function _fmtOnHost(hostname: string | undefined) {
   return hostname ? `on host ${JSON.stringify(hostname)}` : "on any host";
 }
 
-const HOSTNAME_RE = /^(?!-)[\d.A-Za-z-]{1,63}(?<!-)$/;
+const HOSTNAME_RE = /^(?!-)[\d.:A-Za-z-]{1,63}(?<!-)$/;
 
 export function _validateHostname(
   hostname: string | undefined,

diff --git a/test/index.test.ts b/test/index.test.ts
@@ -42,6 +42,14 @@ describe("getPort", () => {
       expect(port3).not.toEqual(3001);
     });
   });
+
+  describe("ipv6", () => {
+    test("get port on ::1", async () => {
+      await blockPort(3000, "::1");
+      const port = await getPort({ host: "::1" });
+      expect(port).not.toBe(3000);
+    });
+  });
 });
 
 describe("random port", () => {