feat: add host option
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we might ideally support host as array to check both 127.0.0.1 (internal) and 0.0.0.0 (external) |
|
Hosts array as default value. That’s really smart! I will try it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
getPort()always checks ports on0.0.0.0.Issue: if some app already listens on
localhost:3000(rather usual indevenvironment),getPort(3000)will return3000. It simply checked if0.0.0.0:3000is free. (Would be good to check, but it sounds similar to issue #3.)Solution: we need a possibility to check
hostandportcombination. In similar situation like abovegetPort({ host: 'localhost' })would return4000.What should be the default value of the
hostoption? Perhaps the same, which is used bylisthen?