Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore unsafe ports #8

Merged
merged 4 commits into from
Apr 11, 2022
Merged

feat: ignore unsafe ports #8

merged 4 commits into from
Apr 11, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe requested a review from pi0 April 11, 2022 14:30
@danielroe danielroe self-assigned this Apr 11, 2022
@pi0
Copy link
Member

pi0 commented Apr 11, 2022

This is a nice fix. Looking more I could find an unofficial blog post with other possibly unsafe ports. Does it makes sense to list and filter them all also for random port allocation?

@pi0 pi0 changed the title fix: omit port 6000 on macOS feat: ignore unsafe ports Apr 11, 2022
@pi0 pi0 merged commit dd29cbd into main Apr 11, 2022
@pi0 pi0 deleted the fix/port-6000 branch April 11, 2022 16:31
@renovate renovate bot mentioned this pull request Jul 29, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants