feat: add useCookie and setCookie utils
#17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
reviewed
Dec 15, 2020
| const cookieObject = Object.fromEntries(cookieEnteries) | ||
|
|
||
| // @ts-ignore | ||
| req.cookie = cookieObject |
There was a problem hiding this comment.
I think we can add an TS assertion that extends the Request object once this function has been called...
There was a problem hiding this comment.
Cache value shouldn't be exposed or implicitly directly accessed.
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Daniel Roe <daniel@roe.dev>
pi0
changed the title
useCookie and setCookie utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added two utility function to work with cookies.
useCookie: Read and parse cookies from requestuseCookieWrite: it receives the response object and return a function to manipulate response header and setSet-Cookieheader.