Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return 'false' and 'null' values as JSON strings #33

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

danielroe
Copy link
Member

resolves #32

@danielroe danielroe added the bug Something isn't working label Sep 9, 2021
@danielroe danielroe requested a review from pi0 September 9, 2021 07:52
@danielroe danielroe self-assigned this Sep 9, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #33 (7a364b5) into main (2576b2a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files          10       10           
  Lines         185      185           
  Branches       50       50           
=======================================
  Hits          174      174           
  Misses         11       11           
Impacted Files Coverage Δ
src/app.ts 96.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2576b2a...7a364b5. Read the comment docs.

@pi0 pi0 merged commit 5613c54 into main Sep 9, 2021
@pi0 pi0 deleted the fix/return-null branch September 9, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returning null throws error cannot read .buffer of null
3 participants