Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): support transpilation of <style> blocks with sass #27

Merged
merged 6 commits into from
Oct 27, 2022
Merged

Conversation

danielroe
Copy link
Member

No description provided.

@danielroe danielroe requested a review from pi0 February 4, 2022 21:35
@danielroe danielroe self-assigned this Feb 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #27 (27a98a7) into main (8f3a513) will increase coverage by 0.76%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   95.37%   96.13%   +0.76%     
==========================================
  Files           6        7       +1     
  Lines         324      388      +64     
  Branches       70       79       +9     
==========================================
+ Hits          309      373      +64     
  Misses         15       15              
Impacted Files Coverage Δ
src/loader.ts 100.00% <100.00%> (ø)
src/loaders/index.ts 100.00% <100.00%> (ø)
src/loaders/sass.ts 100.00% <100.00%> (ø)
src/loaders/vue.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danielroe
Copy link
Member Author

@pi0 Any issue with this pr?

@pi0
Copy link
Member

pi0 commented Oct 15, 2022

Can we lazy import sass dependency and also remove from dependencies? (it can be included from user path).

@pi0 pi0 changed the title feat: support transpilation of <style> blocks feat: support transpilation of <style> blocks with sass Oct 27, 2022
@pi0 pi0 changed the title feat: support transpilation of <style> blocks with sass feat(vue): support transpilation of <style> blocks with sass Oct 27, 2022
@pi0 pi0 merged commit 36e5b4f into main Oct 27, 2022
@pi0 pi0 deleted the feat/sass branch October 27, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants