Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing name and names to ESMExport interface #13

Merged
merged 1 commit into from Oct 22, 2021
Merged

fix: add missing name and names to ESMExport interface #13

merged 1 commit into from Oct 22, 2021

Conversation

flozero
Copy link
Contributor

@flozero flozero commented Oct 22, 2021

Point to https://github.com/nuxt/framework/blob/main/packages/nuxt3/src/auto-imports/composables.ts#L22

As it used ESMExport[]. We should give all possible default values to improve the typing here.

Screen Shot 2021-10-22 at 3 58 34 PM

@pi0 pi0 changed the title update global export typing fix: add missing name and names to ESMExport interface Oct 22, 2021
@pi0 pi0 merged commit c5eacfb into unjs:main Oct 22, 2021
@pi0
Copy link
Member

pi0 commented Oct 22, 2021

Thanks!

@flozero flozero deleted the feat/typescript branch October 22, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants