Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude windows drive letters from protocols #21

Merged
merged 1 commit into from Nov 2, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Oct 30, 2021

resolves nuxt/nuxt#12668
resolves nuxt/nuxt#12688

will also want to port to externality's identical util

@danielroe danielroe requested a review from pi0 October 30, 2021 22:48
@danielroe danielroe self-assigned this Oct 30, 2021
@Suyashtnt
Copy link

How can I test this PR with nuxt 3?

@Suyashtnt
Copy link

after a manual build and link can confirm it works with nuxt 3

@TurningTide
Copy link

confirm that this fix solves nuxt/nuxt#12688

@pi0 pi0 merged commit 94d3506 into main Nov 2, 2021
@pi0 pi0 deleted the fix/exclude-windows-drives branch November 2, 2021 09:27
danielroe added a commit to unjs/externality that referenced this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exports is not defined in ES module scope WARN [SSR] Error transforming on windows
4 participants