Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rate limiter #2168

Open
pi0 opened this issue Feb 25, 2024 · 0 comments
Open

Support rate limiter #2168

pi0 opened this issue Feb 25, 2024 · 0 comments
Labels
discussion enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Feb 25, 2024

It could be a route rule or an external nitro module. (community contribution is welcome! an example template for module: here)

The main thing to note is that any rate limiter implemented to run within the event loop shares some limitations:

  • It can NOT be trusted as a security measurement against DOS attacks.
  • It can barely handle multi instance / cluster deployments

So in general, I would highly advice to depend on a Reverse Proxy (like nginx) or CDN (like cloudflare) to handle rate limiting.

@pi0 pi0 added enhancement New feature or request discussion labels Feb 25, 2024
@pi0 pi0 transferred this issue from unjs/h3 Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant