fix(prerender): remove baseURL from generated file paths

[farnabaz]

🔗 Linked issue

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Generating a project using custom baseURL results unwanted directory inside .output/public.
For example, if you set baseURL = romi-project, you will see a romi-project directory in the generated website. https://github.com/hacknug/romi-project/tree/gh-pages

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[farnabaz]

Maybe I'm wrong about the behavior of Nuxt pretender. Should it generate a subdirectory inside .output/public?

What I think is that the generated website should not have a subdirectory inside it. When I set baseURL in the config, I want to deploy it under a directory in a host. Generating this subdirectory causes duplicate baseURL

Feel free to close this PR if it does not look good :)

[danielroe]

Are you sure the previous PR doesn't resolve this issue? That was initially what I did @farnabaz - check the PR. But we adjusted it to remove the baseURL before the actual fetch call.

[danielroe]

Ah. I think what we actually need to do here is remove the baseURL from the filePath: https://github.com/unjs/nitropack/blob/486f236c1e96134c0ee8021ff5d04e93fe819e75/src/prerender.ts#L66

[farnabaz]

Yes removing baseURL from filePath will do the trick too.

But I think the best way is to remove baseURL from routes and add it in the fetch call. This way we can support URLs like this

/baseUrl/baseUrl/something

Imagine user has a page with the same name as baseURL

[danielroe]

I think that's a good point. But we will still need to update the filenames

[codecov]

Codecov Report

Merging #329 (44aaddd) into main (db1d087) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   55.94%   55.95%   +0.01%     
==========================================
  Files          54       54              
  Lines        3466     3467       +1     
  Branches      362      362              
==========================================
+ Hits         1939     1940       +1     
  Misses       1178     1178              
  Partials      349      349              

Impacted Files	Coverage Δ
src/prerender.ts	66.43% <100.00%> (+0.23%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db1d087...44aaddd. Read the comment docs.

[pi0]

LGTM. We might add a symbolic link to avoid breaking change and allow cases when public structure is expected to have base url