Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to install dependencies with a frozen lockfile #121

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

RyanClementsHax
Copy link
Contributor

πŸ”— Linked issue

Closes #115

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Closes #115

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.51%. Comparing base (660392f) to head (8c6b5f3).
Report is 25 commits behind head on main.

Files Patch % Lines
src/cli.ts 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (660392f) and HEAD (8c6b5f3). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (660392f) | HEAD (8c6b5f3) | |------|------|------| ||3|2|
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   82.17%   72.51%   -9.66%     
==========================================
  Files           6        6              
  Lines         516      655     +139     
  Branches       71       85      +14     
==========================================
+ Hits          424      475      +51     
- Misses         91      177      +86     
- Partials        1        3       +2     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@RyanClementsHax
Copy link
Contributor Author

The root error in CI seems to be this failing test that only failed on windows. The second test that failed errored because it depended on this test succeeding.

   ❯ test/api-workspace.test.ts > api > yarn-classic-workspace > adds dependency to the workspace root
     β†’ Command failed with exit code 1: corepack yarn -W add pathe
Internal Error: ENOTEMPTY: directory not empty, rmdir 'C:\Users\runneradmin\AppData\Local\node\corepack\yarn\1.22.19\lib'

I checked locally on my windows machine if this was a reproducible problem and it doesn't seem to be. The internet seems to consider this error as ephemeral and solved by deleting node_modules and reinstalling.

I'm inclined to rerun the action because of this and the install command isn't run on the workspace fixtures. What do you think @pi0?

Also, I'd be happy to add install tests to the workspace tests. Given their lack, I wanted to see what the reasoning was for there not being any before adding them.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. windows CI seems to be passing now!

@pi0 pi0 merged commit aafa4f6 into unjs:main Jun 28, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installDependencies frozen lockfile option
2 participants