Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct flag when getting pnpm workspace args #130

Merged
merged 5 commits into from
Jun 28, 2024
Merged

fix: use correct flag when getting pnpm workspace args #130

merged 5 commits into from
Jun 28, 2024

Conversation

DamianGlowala
Copy link
Contributor

@DamianGlowala DamianGlowala commented May 15, 2024 •
edited
Loading

🔗 Linked issue

resolves #123

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Uses correct flag when getting pnpm workspace args (-F/--filter).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.66%. Comparing base (660392f) to head (d9a3b23).
Report is 23 commits behind head on main.

❗ Current head d9a3b23 differs from pull request most recent head 7ac18e0

Please upload reports for the commit 7ac18e0 to get more accurate results.

❗ There is a different number of reports uploaded between BASE (660392f) and HEAD (d9a3b23). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (660392f) | HEAD (d9a3b23) | |------|------|------| ||3|2|
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   82.17%   72.66%   -9.51%     
==========================================
  Files           6        6              
  Lines         516      633     +117     
  Branches       71       83      +12     
==========================================
+ Hits          424      460      +36     
- Misses         91      170      +79     
- Partials        1        3       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pi0
pi0 reviewed Jun 28, 2024
View reviewed changes
src/_utils.ts Outdated Show resolved Hide resolved
@pi0 pi0 merged commit 088096a into unjs:main Jun 28, 2024
4 checks passed
@pi0
Copy link
Member

pi0 commented Jun 28, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

workspace option is not actually working when using PNPM
2 participants
@DamianGlowala @pi0