Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only call error handler if status code is >= 400 #153

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Conversation

danielroe
Copy link
Member

resolves #150

@danielroe danielroe added the bug Something isn't working label Oct 27, 2022
@danielroe danielroe requested a review from pi0 October 27, 2022 09:29
@danielroe danielroe self-assigned this Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #153 (e57922e) into main (63232f5) will decrease coverage by 0.22%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   85.89%   85.66%   -0.23%     
==========================================
  Files           5        5              
  Lines         319      321       +2     
  Branches       60       60              
==========================================
+ Hits          274      275       +1     
- Misses         45       46       +1     
Impacted Files Coverage Δ
src/fetch.ts 86.48% <85.71%> (-0.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 385f7fe into main Oct 27, 2022
@pi0 pi0 deleted the fix/error-by-code branch October 27, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$fetch throws error for 30x response codes
2 participants