Empty body is converted to ''

[leopiccionia]

While migrating an app to ohmyfetch, one assertion on my test suite started to fail on a rather surprising way: the library return "" for responses with empty body (e.g. typical DELETE responses) instead of null or undefined.

If I follow the documentation, I can see why: the library will try to parse the response as JSON as default and, if it fails, as string. Them a body with length == 0 is parsed as an empty string.

While I can understand this behavior, it sounded counter-intuitive to me to return some value if the server intended to return nothing.

If you think this is by-design and not a bug, feel welcome to close it.

[pi0]

Hi @leopiccionia. Nice spot! You can directly respond null to get native null as the result. But i think we can improve the behavior. Do you mind to share exact curl -Iv [URL] output of your API? What are Content-Type and Content-Length for API routes?

[leopiccionia]

It's for a third-party REST API that requires an API key, etc. So it's hard to setup a proper reproduction. My source code is here, though.

For context, it's a DELETE REST endpoint, that returns nothing on success (204 No Content) or a JSON object on failure.

I could extract the following headers from $fetch.raw:

{
  'access-control-allow-origin': '*',
  connection: 'close',
  'content-type': 'application/json; charset=UTF-8',
  date: 'Sat, 04 Jun 2022 16:27:11 GMT',
  server: 'nginx'
}