Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: badge syntax and samples in readme #12

Closed
wants to merge 1 commit into from
Closed

fix: badge syntax and samples in readme #12

wants to merge 1 commit into from

Conversation

NozomuIkuta
Copy link
Member

I found that badges in README are not rendered correctly in NPM and GitHub, and that sample URLS are a little too far away from where they are supposed to be used and rendered unnecessarily.

This PR is to fix the badge syntax and comment out sample URLS near the badges.

@pi0
Copy link
Member

pi0 commented Aug 25, 2022

Hi thanks for PR but badges keep working. Also since badge links are one time only, I prefer to keep them in footer. Focusing on writing docs from top.

@NozomuIkuta
Copy link
Member Author

Ohh, I found it by googling that there are ways to define link attributes afterwards in markdown!
Excuse me, I didn't know that. 😿

Now I see all your intention.
I might have broken some syntax while writing docs and thought that it doesn't work.

Everything is fine, so let me close this PR. 👏

@NozomuIkuta NozomuIkuta deleted the fix/readme branch August 27, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants