Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decouple resolveURL from $URL #36

Closed
pi0 opened this issue Aug 17, 2021 · 0 comments · Fixed by #186
Closed

decouple resolveURL from $URL #36

pi0 opened this issue Aug 17, 2021 · 0 comments · Fixed by #186

Comments

@pi0
Copy link
Member

pi0 commented Aug 17, 2021 •
edited

ufo/resolveURL was originally based on native URL but then due to platform differences and need for polyfill, we switched to lighter utils.

Using createURL/$URL for resolveURL does unnecessary encoding/decoding and adds more to the bundle. We can internally use parseURL now.

Also, we can still keep $URL it as a ponyfill but docs need to be improved it is not exactly the same as whatwg URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(resolveUrl): decouple from $URL DaniAcu/ufo
1 participant
@pi0