Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override urls with protocol with withBase #67

Closed
pi0 opened this issue Jul 29, 2022 · 1 comment · Fixed by #68
Closed

override urls with protocol with withBase #67

pi0 opened this issue Jul 29, 2022 · 1 comment · Fixed by #68
Assignees
@danielroe

Comments

@pi0
Copy link
Member

pi0 commented Jul 29, 2022

Reference: unjs/ofetch#113

Current behavior:

// http://base/http://domain
ufo.withBase('http://domain', 'http://base')

New behavior:

// http://domain
ufo.withBase('http://domain', 'http://base'})

URL behavior:

// http://domain/
new URL('http://domain', 'http://base').toString()
@pi0 pi0 mentioned this issue Jul 29, 2022
Closed
@pi0
Copy link
Member Author

pi0 commented Jul 29, 2022

@danielroe Would you like to pick this?

@danielroe danielroe self-assigned this Jul 29, 2022
@danielroe danielroe mentioned this issue Jul 29, 2022
Merged
@pi0 pi0 closed this as completed in #68 Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielroe danielroe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure withBase does not prefix URLs with protocol unjs/ufo
2 participants
@pi0 @danielroe