Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check if awaitable is an object #43

Merged
merged 2 commits into from Nov 28, 2022
Merged

fix: check if awaitable is an object #43

merged 2 commits into from Nov 28, 2022

Conversation

manniL
Copy link
Member

@manniL manniL commented Nov 27, 2022 •
edited

Resolves nuxt/nuxt#15778

Adds a check if awaitable is an object to avoid obscure errors for end users. Also adds tests to ensure the functionality is not affected

pi0
pi0 reviewed Nov 28, 2022
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
pi0
pi0 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@pi0 pi0 merged commit 25f9909 into unjs:main Nov 28, 2022
@manniL manniL deleted the fix/await-with-no-async-fn branch November 28, 2022 12:15
@manniL manniL mentioned this pull request Dec 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Cannot use 'in' operator to search for 'catch' in undefined" when using pinia in the plugin
2 participants
@manniL @pi0