Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchpad scrolling crashes game #2909

Open
t-karcher opened this issue May 21, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@t-karcher
Copy link

commented May 21, 2019

Using two-finger scrolling on my touchpad immediately crashes the game, even in the start menu. Mouse wheel scrolling works as expected (does nothing in the menu, scrolls just fine in the game).

Steps to reproduce:
Start game, scroll anywhere (up, down, left, right) using the two-finger gesture on the touchpad. Game crashes.

Python version: sys.version_info(major=3, minor=7, micro=0, releaselevel='final', serial=0)
Platform: Windows-10-10.0.17134-SP0
Using fife version 0.4.2, at least 0.4.2 required
(Unknown-Horizons-2019.1.214-Setup-VC15-x86.exe)

@t-karcher t-karcher changed the title Trackpad scrolling crashes game Touchpad scrolling crashes game May 21, 2019

@jmdejong

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

This looks similar to #2753 which I thought I fixed before (in #2829, which is in 2019.1).
Does this indeed happen with any horizontal scrolling?

@t-karcher

This comment has been minimized.

Copy link
Author

commented May 22, 2019

Yes, moving two fingers anywhere in any game state leads to an immediate crash. I first came across this when I tried zooming in the map with the touchpad zoom gesture, but it also crashes in the menu directly after startup when moving two fingers in any direction on the touchpad.

@jmdejong

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

ok, my guess now is that it's not related to the previous scrolling issues, but it is a problem in FIFE in handling the events.

The latest version of SDL has the SDL_FINGERMOTION event type, but fife's eventmanager has a switch statement that does not include that event or a default case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.