Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound upon vehicle hit #166

Closed
LavaHoleD opened this issue Feb 6, 2023 · 3 comments
Closed

Sound upon vehicle hit #166

LavaHoleD opened this issue Feb 6, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@LavaHoleD
Copy link

LavaHoleD commented Feb 6, 2023

A new kind of sound: when a vehicle is hit, it will play a configurable sound/s defined in the vehicle config file and stored in the assets folder.

It could be done in three ways:
1. The simplest one: simply a new parameter which redirect to a sound.
2. The intermediate one: it will play an array of sounds (ex. vehicleHitSound sfx1, sfx2, sfx3).
3. The hard one: it will play a different sound depending on the damage value the vehicle has taken.

Edit: actually I just realized that there is a big difference between low caliber impact sounds and high caliber impact sounds. Perhaps it would have to be a bit more specific, maybe having a different sound based on the type of entity bullet that hit it.

Edit n2: yeah probably it would be a lot easier to add a parameter for ammo configs directly for vehicle hit sound.

It would be a small neat feature to improve realism

@GoldSloth
Copy link
Collaborator

There's already a hitmarker sound that plays for the shooter, but I agree a version that plays for the hit vehicle would make sense. It might be a bit tricky to get the config organised well, because of the different combinations of bullets and vehicles. Overall it's a low priority feature though so we're unlikely to get to it - I'll add it to the Trello board though.

Thanks for the suggestion:)

@GoldSloth GoldSloth added the enhancement New feature or request label Feb 7, 2023
@LavaHoleD
Copy link
Author

No problem and no worries! Keep up the good work!

@GoldSloth
Copy link
Collaborator

Tracked by #179

Please reopen or new issue if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants