Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minWidth fixed to 1024px #3

Closed
aogaili opened this issue Oct 9, 2017 · 4 comments
Closed

minWidth fixed to 1024px #3

aogaili opened this issue Oct 9, 2017 · 4 comments

Comments

@aogaili
Copy link

aogaili commented Oct 9, 2017

Hello - first thanks for this great wrapper, really easy to setup.

I'm unable to override the min width property of the iframe and it's getting overflown from the parent container, any idea how to fix this?

Thanks

@aogaili
Copy link
Author

aogaili commented Oct 9, 2017

Ok I just used the following CSS

#editor iframe {
  min-width: 100% !important;
}

But I think it's useful to have that configurable..

@adeelraza
Copy link
Contributor

@aliogaili we have it fixed for 1024px because that is the minimum recommended width. Below that, there may not be enough space for the editor to function properly.

@aogaili
Copy link
Author

aogaili commented Oct 10, 2017

Thanks @adeelraza so it's by design.

But what are the effects of decreasing the width that you know of? it seems to be working fine with 930px ?

@aogaili aogaili closed this as completed Oct 10, 2017
@adeelraza
Copy link
Contributor

@aliogaili in most cases, it won't be a problem. However, if your user decides to increase the body width over the usual, then it may become harder to edit the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants