Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case for weight type #46

Closed
sighphyre opened this issue Jan 20, 2023 · 1 comment
Closed

Add case for weight type #46

sighphyre opened this issue Jan 20, 2023 · 1 comment
Labels
enhancement New feature or request stale

Comments

@sighphyre
Copy link
Member

sighphyre commented Jan 20, 2023

Describe the feature request

Currently there's no test case for a variant that specifies a weight type

Background

This is assumed to be variable if not specified but this is an import case for ensuring that the client response is correctly parsed, since it's very easy to miss when building an implementation and if the implementation doesn't ignore unknown fields or handle this then it'll fail to parse

Solution suggestions

Add a test case for this

@sighphyre sighphyre added the enhancement New feature or request label Jan 20, 2023
@stale
Copy link

stale bot commented Feb 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 19, 2023
@stale stale bot closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
Archived in project
Development

No branches or pull requests

1 participant