Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getFeatureToggleDefinition to Unleash interface #161

Closed
Chaosmi opened this issue Jun 28, 2022 · 2 comments
Closed

Add getFeatureToggleDefinition to Unleash interface #161

Chaosmi opened this issue Jun 28, 2022 · 2 comments
Assignees
@andreas-unleash
Labels
enhancement

Comments

@Chaosmi
Copy link
Contributor

Chaosmi commented Jun 28, 2022 •
edited
Loading

Describe the feature request

Would it be possible to add getFeatureToggleDefinition to Unleash interface so we don't have to refer to concrete DefaultUnleash?

Background

This will mean we can refer to the interface only and avoid casting to DefaultUnleash

Solution suggestions

Raised PR #160
@andreas-unleash
Copy link
Contributor

andreas-unleash commented Jun 29, 2022 •
edited
Loading

Hey, thank you for reaching out and your PR. I left a comment about where Ithink this functionality could sit

@chriswk
Copy link
Contributor

chriswk commented Oct 6, 2022

Your PR is merged and included in 6.1.0 of unleash-client-java. Currently propagating it's way to maven mirrors.

@chriswk chriswk closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreas-unleash andreas-unleash

Labels
enhancement
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chriswk @Chaosmi @andreas-unleash