Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric Bucket + Client Features Flag list #85

Closed
Green-Apple opened this issue Aug 19, 2019 · 1 comment
Closed

Metric Bucket + Client Features Flag list #85

Green-Apple opened this issue Aug 19, 2019 · 1 comment

Comments

@Green-Apple
Copy link

I noticed no.finn.unleash.metric.MetricsBucket is a non-public class, is that intentional? I was hoping to retrieve the MetricBucket via the UnleashSubscriber.clientMetrics() event to capture a Set of the feature flags the client is checking for. This could be a quick way to identify feature flags that exist (and are being called) in the client, that may not exist on the server yet. Unless there is a better alternative way for the client to know what feature flags exist within the client code base. I know from the Unleash server side, for a given application, I can get a list of Feature flags that have been triggered on the client, but are not defined on the server. I'm trying to do a similar thing, just from the client side.

@ivarconr
Copy link
Member

It's non public because it's subject to change in upcoming versions (I want to rethink the metrics part a bit to get more derails, e.g. which strategy contributed to evaluating this toggle to true).

Your question is valid though. It would probably be nice if the clients expose metrics. I see multiple usages for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants