Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: metrics only sent if not empty #58

Closed
ivarconr opened this issue Sep 29, 2021 · 2 comments
Closed

fix: metrics only sent if not empty #58

ivarconr opened this issue Sep 29, 2021 · 2 comments

Comments

@ivarconr
Copy link
Member

The Ruby SDK sent metrics even if it is empty. Instead it can hold on to the local metrics longer if there are no metrics to report (e.g. up to 10min).
@rarruda
Copy link
Collaborator

rarruda commented Oct 25, 2021

Is there a sample implementation in other sdk's of this feature? (I couldn't find at first glance, but didn't look too deep either) Should we make the configurable the timeout for not reporting empty metrics?

rarruda added a commit that referenced this issue Nov 13, 2021
@rarruda
fix: only send metrics if there is data to send. (#58)
7736028 
We want to preserve the backend from having to work, when there is no work to be done.
rarruda added a commit that referenced this issue Dec 2, 2021
@rarruda
fix: only send metrics if there is data to send. (#58)
5cb50ab 
We want to preserve the backend from having to work, when there is no work to be done.
rarruda added a commit that referenced this issue Dec 5, 2021
@rarruda
fix: only send metrics if there is data to send. (#58)
e812e15 
We want to preserve the backend from having to work, when there is no work to be done.
rarruda added a commit that referenced this issue Dec 16, 2021
@rarruda
fix: only send metrics if there is data to send. (#58)
090b803 
We want to preserve the backend from having to work, when there is no work to be done.
rarruda added a commit that referenced this issue Dec 16, 2021
@rarruda
fix: only send metrics if there is data to send. (#58)
ea72260 
We want to preserve the backend from having to work, when there is no work to be done.
@rarruda
Copy link
Collaborator

rarruda commented Dec 16, 2021

This feature is now merged in master.

@rarruda rarruda closed this as completed Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivarconr @rarruda