Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol health check zkSync, zkEVM, Scroll #13505

Closed
julien51 opened this issue Mar 22, 2024 · 3 comments
Closed

Protocol health check zkSync, zkEVM, Scroll #13505

julien51 opened this issue Mar 22, 2024 · 3 comments
Assignees

Comments

@julien51
Copy link
Member

julien51 commented Mar 22, 2024

It looks like these are currently now setup correctly based on the healthcheck output:

Running task for the following networks: arbitrum,avalanche,base,bsc,celo,gnosis,goerli,linea,mainnet,mumbai,optimism,polygon,scroll,sepolia,zkevm,zksync
[Ethereum]: ⚠️  Unlock owner is not the team multisig (0x9168EABE624e9515f3836bA1716EC1DDd4C461D4)!
[Scroll]: ⚠️  ERROR: Failed to fetch ProxyAdmin address
[Scroll]: ⚠️  Unlock contract and ProxyAdmin have different owners!
[zkEVM (Polygon)]: ⚠️  ERROR: Failed to fetch ProxyAdmin address
[zkEVM (Polygon)]: ⚠️  Unlock contract and ProxyAdmin have different owners!
[zkSync Era]: ⚠️  ERROR: Failed to fetch ProxyAdmin address
[zkSync Era]: ⚠️  Unlock contract and ProxyAdmin have different owners!
[zkSync Era]: ⚠️  Unlock owner is not the team multisig (0xFa5592CE9C52FA5214ccEa10cB72Faa88eC80a3c)!
@clemsos
Copy link
Member

clemsos commented Mar 25, 2024

fixed the way proxy admin address is fetched in #13517 and transferred ownership of zksync contracts to team multisig

@clemsos clemsos closed this as completed Mar 25, 2024
@julien51 julien51 reopened this Mar 25, 2024
@julien51
Copy link
Member Author

Thanks! It looks like we still have an issue with Scroll

Error HH110: Invalid JSON-RPC response received: Something went wrong! Team has been notified.

For more info go to https://hardhat.org/HH110 or run Hardhat with --show-stack-traces
node:child_process:965
    throw err;
    ^

Error: Command failed: yarn hardhat --network scroll unlock:info --quiet
    at checkExecSyncError (node:child_process:890:11)
    at execSync (node:child_process:962:15)
    at Object.<anonymous> (/Users/julien/repos/unlock/governance/all_networks:30:3)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47 {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 87139,
  stdout: null,
  stderr: null
}

@julien51
Copy link
Member Author

All good!

yarn run check                     
Running task for the following networks: arbitrum,avalanche,base,bsc,celo,gnosis,linea,mainnet,mumbai,optimism,polygon,scroll,sepolia,zkevm,zksync
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
[Ethereum]: ⚠️  ProxyAdmin owner is not the team multisig
[Ethereum]: ⚠️  Unlock owner is not the team multisig
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.
⚠️ Using account from DEPLOYER_PRIVATE_KEY environment variable.

We will need to take care of warning on mainnet eventually!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants