Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(smart-contracts): UP/UDT swap contract #13876

Merged
merged 30 commits into from
Jun 27, 2024
Merged

feat(smart-contracts): UP/UDT swap contract #13876

merged 30 commits into from
Jun 27, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented May 21, 2024

Description

This is a contract to swap UDT for UP.

Unlock Labs is planning to submit a proposal to the DAO to "move" to Base. This includes deploying a new Governor Contract, a new Timelock contract, as well as a new governance token contract, called UPToken. (Unlock Protocol Token).
However, we want this new token to be a "replacement" for the legacy UDT contract, which means that the only way to "receive" UP tokens is to bridge UDT to Base and then send the UDT tokens to a Swap contract. The amount of UP tokens received is based on a fixed redeem rate of 1000 for 1.

We also want the contract to support the "opposite" operation that would let anyone who owns UP tokens redeem them for legacy UDT, as the inverse rate of 1000 for 1.

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label May 21, 2024
@clemsos
Copy link
Member Author

clemsos commented May 21, 2024

relates to #13875

@clemsos clemsos marked this pull request as ready for review May 23, 2024 12:49
@clemsos clemsos requested a review from julien51 May 24, 2024 14:03
@julien51
Copy link
Member

ok @bytes032, this is the PR in which we're adding the contract to be audited. Please bear with us as we're cleaning this up!

@julien51
Copy link
Member

@clemsos please confirm we need to rebase after #13875 has been merged?

@clemsos
Copy link
Member Author

clemsos commented May 28, 2024

@clemsos please confirm we need to rebase after #13875 has been merged?

Yes I just merged and rebased

@julien51
Copy link
Member

Hey @marvinkruse please check this PR regarding the audit!

@marvinkruse
Copy link

Hey @julien51 - thank you for tagging me, checking it out!

@clemsos clemsos merged commit 47ffcb5 into master Jun 27, 2024
12 checks passed
@clemsos clemsos deleted the up-swap-contract branch June 27, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants