Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting CBWallet on mobile checkout reverts and repeats steps 1 and 2 in checkout #14029

Closed
ccarfi opened this issue Jun 10, 2024 · 7 comments
Assignees

Comments

@ccarfi
Copy link
Contributor

ccarfi commented Jun 10, 2024

Describe the bug
Selecting CBWallet on mobile checkout reverts and repeats steps 1 and 2 in checkout

To Reproduce
Going to a checkout on mobile, select a lock and select Coinbase wallet

Steps 1 and 2 of the checkout are repeated before being able to proceed

cbwallet-mobile-checkout-step1-2-repeat-trim.mov
@julien51
Copy link
Member

I suspect this is because staging is broken.

@ccarfi ccarfi reopened this Jun 19, 2024
@ccarfi
Copy link
Contributor Author

ccarfi commented Jun 19, 2024

saw this again on prod when testing subscriptions on 19jun2024

@julien51 julien51 assigned SVell and unassigned julien51 Jun 19, 2024
@julien51
Copy link
Member

Confirmed and reproduced. When starting from a mobile browser (Chrome on Android) and then selecting the Coinbase Wallet, it opens the in-app browser but does not keep the "state" (selected lock...). @SVell since this feels pretty similar to what we have with OAuth (Google), do you think we could open up the Coinbase in-app browser while keeping the "selected lock" state? Ideally, even the fact that the user has chose Coinbase wallet so we are just at the point where we ask the use to sign the SIWE message?

@SVell
Copy link
Contributor

SVell commented Jun 20, 2024

@julien51 it is possible, the coinbase wallet just opens the site in the built-in browser, that's why it resets checkout. We can add a query to mark the selected lock in the checkout and then check for it, but should we really do this?

@julien51
Copy link
Member

@julien51 it is possible, the coinbase wallet just opens the site in the built-in browser, that's why it resets checkout. We can add a query to mark the selected lock in the checkout and then check for it, but should we really do this?

I think we can but we should "remove" the query string as soon as this page is loaded in Coinbase Wallet so that the URL is "clean" again. wdyt?

@SVell
Copy link
Contributor

SVell commented Jun 21, 2024

@julien51 it is possible, the coinbase wallet just opens the site in the built-in browser, that's why it resets checkout. We can add a query to mark the selected lock in the checkout and then check for it, but should we really do this?

I think we can but we should "remove" the query string as soon as this page is loaded in Coinbase Wallet so that the URL is "clean" again. wdyt?

Possible, I am doing the same with Connect Modal for Next Auth rn

@julien51
Copy link
Member

Possible, I am doing the same with Connect Modal for Next Auth rn

Ok, great, please do it here too then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants