-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selecting CBWallet on mobile checkout reverts and repeats steps 1 and 2 in checkout #14029
Comments
I suspect this is because staging is broken. |
saw this again on prod when testing subscriptions on 19jun2024 |
Confirmed and reproduced. When starting from a mobile browser (Chrome on Android) and then selecting the Coinbase Wallet, it opens the in-app browser but does not keep the "state" (selected lock...). @SVell since this feels pretty similar to what we have with OAuth (Google), do you think we could open up the Coinbase in-app browser while keeping the "selected lock" state? Ideally, even the fact that the user has chose Coinbase wallet so we are just at the point where we ask the use to sign the SIWE message? |
@julien51 it is possible, the coinbase wallet just opens the site in the built-in browser, that's why it resets checkout. We can add a query to mark the selected lock in the checkout and then check for it, but should we really do this? |
I think we can but we should "remove" the query string as soon as this page is loaded in Coinbase Wallet so that the URL is "clean" again. wdyt? |
Possible, I am doing the same with Connect Modal for Next Auth rn |
Ok, great, please do it here too then! |
Describe the bug
Selecting CBWallet on mobile checkout reverts and repeats steps 1 and 2 in checkout
To Reproduce
Going to a checkout on mobile, select a lock and select Coinbase wallet
Steps 1 and 2 of the checkout are repeated before being able to proceed
cbwallet-mobile-checkout-step1-2-repeat-trim.mov
The text was updated successfully, but these errors were encountered: