Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unlock-app): Deploy subscription #14067

Merged
merged 11 commits into from
Jun 19, 2024
Merged

feat(unlock-app): Deploy subscription #14067

merged 11 commits into from
Jun 19, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Jun 18, 2024

Description

We're adding a form to "easily" deploy subscriptions, with a simplified form.

I am moving USDC to be the "first" token on every network so that it provides a good default.

https://www.loom.com/share/703ce1fc11e94d44b17ac086497eac1c?from_recorder=1&focus_title=1

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@cla-bot cla-bot bot added the cla-signed label Jun 18, 2024
@julien51 julien51 changed the title Deploy subscription feat(unlock-app): Deploy subscription Jun 18, 2024
@julien51 julien51 marked this pull request as ready for review June 18, 2024 15:57
Copy link
Member

@clemsos clemsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julien51 julien51 merged commit f9928e5 into master Jun 19, 2024
12 checks passed
@julien51
Copy link
Member Author

Fixes #14024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants