Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Creation transactions stuck in "Submitted" state #2757

Closed
cnasc opened this issue Apr 19, 2019 · 7 comments
Closed

Lock Creation transactions stuck in "Submitted" state #2757

cnasc opened this issue Apr 19, 2019 · 7 comments
Assignees
Labels
frontend architecture and design->code for the unlock app frontend
Projects

Comments

@cnasc
Copy link
Contributor

cnasc commented Apr 19, 2019

Describe the bug
On the creator dashboard, some transactions always show as "Submitted". We need to investigate that and fix it.

To Reproduce
This is visible on staging, if you have already created some locks you should see 1 or 2.

image

These lock creations also have some missing data in Redux:

image

I believe that the transactions which only have hashes are in that state because of unrelated contract issues, but the two with additional metadata are the locks in the screenshot above.

@cnasc cnasc added p-1 frontend architecture and design->code for the unlock app frontend labels Apr 19, 2019
@cnasc cnasc self-assigned this Apr 19, 2019
@cnasc cnasc added this to To do in Unlock App via automation Apr 19, 2019
@cnasc
Copy link
Contributor Author

cnasc commented Apr 19, 2019

I am so far unable to reproduce this locally

@cellog
Copy link
Contributor

cellog commented Apr 19, 2019

The bug is one I have seen many times, including locally. It seems it is caused by the lock address guesser guessing that the lock will be the next value. In other words, if you were to refresh and create another lock, it would have address 0x0250...

@cnasc
Copy link
Contributor Author

cnasc commented Apr 19, 2019

Not sure if we're talking about the same thing, these locks persistently show in this state, not just temporarily after creation

@cellog
Copy link
Contributor

cellog commented Apr 19, 2019

ah, even on refresh you see 2 locks?

@cnasc
Copy link
Contributor Author

cnasc commented Apr 19, 2019

Yep

@cnasc
Copy link
Contributor Author

cnasc commented Apr 19, 2019

Aha. Contract fix has deployed, which cleared up a number of things. Now there is only one lock stuck at "Submitted" and here's why:

image

Two transactions for the same lock.

Edit: this is not the issue, that's one lock creation and a key purchase...

@cnasc
Copy link
Contributor Author

cnasc commented Apr 19, 2019

This may be resolved

@cnasc cnasc closed this as completed Apr 20, 2019
Unlock App automation moved this from To do to Done Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend architecture and design->code for the unlock app frontend
Projects
No open projects
Unlock App
  
Done
Development

No branches or pull requests

2 participants