Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas refund from lock #7774

Closed
julien51 opened this issue Nov 15, 2021 · 1 comment · Fixed by #7796 or #8001
Closed

Gas refund from lock #7774

julien51 opened this issue Nov 15, 2021 · 1 comment · Fixed by #7796 or #8001
Assignees
Labels
smart contract Smart contract related issue or task

Comments

@julien51
Copy link
Member

julien51 commented Nov 15, 2021

We want the locks to be able to refund gas to the msg.sender of the transaction.
Right now any address can purchase a membership on behalf of someone else (because the purchase function has a beneficiary address.
We need to add the ability for the lock owner to set a percentage of the key price to be refunded to the sender. By default it should be 0.

This will enable better key purchases through credit cards, as well as cross-chain transactions.

@julien51 julien51 added the smart contract Smart contract related issue or task label Nov 15, 2021
@clemsos clemsos mentioned this issue Nov 19, 2021
6 tasks
@julien51 julien51 added the v9 label Dec 3, 2021
@julien51 julien51 reopened this Jan 5, 2022
@julien51
Copy link
Member Author

julien51 commented Jan 5, 2022

Let's actually change the approach and use a fixed value for the gas refund.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smart contract Smart contract related issue or task
Projects
None yet
2 participants