Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--version and --help commands should return 0 status code #222

Closed
gabceb opened this issue Oct 9, 2014 · 3 comments
Closed

--version and --help commands should return 0 status code #222

gabceb opened this issue Oct 9, 2014 · 3 comments

Comments

@gabceb
Copy link

gabceb commented Oct 9, 2014

if --version and --help command execute successfully they should return 0 instead of 255. I checked some of the most commonly used command line tools (git, grep, vim, etc) and they all return 0 on --version and --help.

I ran into this issue when using unoconv --version to check if unoconv was installed properly.

I can provide a PR unless someone disagrees with this.

@gabceb gabceb changed the title --version and --help commands should return 0 code --version and --help commands should return 0 status code Oct 9, 2014
@dagwieers
Copy link
Member

You are correct, a PR would be appreciated.

@dagwieers dagwieers added this to the Release 0.7 milestone Jul 5, 2015
@gabceb
Copy link
Author

gabceb commented Jul 5, 2015

Thanks @dagwieers. Sorry that I missed your previous comment

@dagwieers
Copy link
Member

No problem. I try to engage people to look at the code, especially for trivial matters :-)
I don't know why it wasn't returning 0 from the very start though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants