Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot open password protected files even if password is known #357

Closed
monomelodies opened this issue Oct 7, 2016 · 2 comments
Closed

Comments

@monomelodies
Copy link
Contributor

I needed to programmatically strip the password from an office doc (.xlsx in my case, but shouldn't matter). I noticed the help says one may pass --password, but in the code it's commented out. It was also attempting to pass the password protecting single sheets instead of the whole file (which makes much more sense IMO for this feature).

After hacking around a bit, I got it to work. Shall I submit a PR? I realise this changes the possibly intended working of the feature, but since it didn't, ehm, work in the first place I don't think that's an issue.

Cheers,
Marijn

@monomelodies
Copy link
Contributor Author

Sod it, I made a pull request. I think it should be merged ASAP, it makes the feature work as advertised.

@regebro
Copy link
Member

regebro commented Feb 28, 2019

This was merged.

@regebro regebro closed this as completed Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants