Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in #1028 caused by missing navigationview resources #1170

Closed
Assignees
Labels
kind/bug Something isn't working

Comments

@jeromelaban
Copy link
Member

Current behavior

#1028 removed the MaterialNavigationViewBackground key (and probably others) which may be an unwanted breaking change.

Expected behavior

Apps using older versions of themes should still be compatible with 2.7 builds of uno.themes.

How to reproduce it (as minimally and precisely as possible)

Environment

Nuget Package: 2.7.0

@jeromelaban jeromelaban added the kind/bug Something isn't working label Aug 29, 2023
@agneszitte
Copy link
Contributor

fyi @kazo0

@agneszitte
Copy link
Contributor

We will need to do a Migration doc for theme/toolkit in order to list the breaking changes regarding lightweight styling work

@Xiaoy312
Copy link
Contributor

Xiaoy312 commented Sep 7, 2023

styles diff log for themes+toolkit: 20230906 migration doc.md
^ script method: Specialized.ListExposedThemeV2Styles();
^ script method: Specialized.ListExposedToolkitV2Styles();

inner resources diff log for themes: diff-log.md
inner resources diff log for toolkit: toolkit-ctrl-res-diff-log.md
^ script method: Specialized.DiffThemeV2InnerResources();

relevant script: 20220412 resource parser.linq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment