Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All][TextBox] Placeholder Text not Vertically Centered #842

Open
3 of 6 tasks
Soap-141 opened this issue Sep 7, 2022 · 5 comments · Fixed by #843
Open
3 of 6 tasks

[All][TextBox] Placeholder Text not Vertically Centered #842

Soap-141 opened this issue Sep 7, 2022 · 5 comments · Fixed by #843
Assignees
Labels
kind/bug Something isn't working

Comments

@Soap-141
Copy link
Contributor

Soap-141 commented Sep 7, 2022

Current behavior

When using a TextBox with MaterialOutlineTextBoxStyle the placeholder text is not vertically centered.

Capture_97

Expected behavior

When using a TextBox with MaterialOutlineTextBoxStyle the placeholder text should be vertically centered.

How to reproduce it (as minimally and precisely as possible)

  1. Download MyApp.zip
  2. Open solution
  3. Start project
  4. Notice Placeholder Text in the TextBox is not vertically centered

Environment

Nuget Package:

  • Uno.WinUI
  • Uno.Material.WinUI

Package Version(s):

  • 4.5.0-dev.802
  • 2.3.0-dev.12

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • UWP
  • WinUI
  • MacOS

Anything else we need to know?

@Soap-141
Copy link
Contributor Author

Not fixed in 2.3.0-dev.20
image

@Soap-141 Soap-141 reopened this Sep 12, 2022
@agneszitte
Copy link
Contributor

Syncing with @Soap-141 at the moment to make sure of the nuget package version and the sample app he used for his tests

@agneszitte
Copy link
Contributor

agneszitte commented Sep 12, 2022

So after syncing with @Soap-141 regarding the vertical alignment issue for the TextBox, Thomas did a sample app but there were no font files added to the sample so it was using the default font.

Uno.Themes for Material is using Roboto font and the project is using EncodeSansCondensed font.

So I'm trying to make sure placeholder and editable text are properly vertically aligned in the style regarding what font is used at the end

@kazo0 kazo0 removed their assignment Sep 13, 2022
@agneszitte agneszitte removed their assignment Jan 26, 2023
@agneszitte
Copy link
Contributor

agneszitte commented Jan 26, 2023

@jeromelaban, @kazo0 with all of the changes for the fonts lately I'm not sure if this issue is still relevant
What should we do next for this one?

@Xiaoy312
Copy link
Contributor

should be covered within #974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants