Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ToggleSwitch knob does not respect the Foreground property #903

Merged
merged 3 commits into from Dec 22, 2022

Conversation

agaldanaw2
Copy link
Contributor

@agaldanaw2 agaldanaw2 commented Dec 21, 2022

closes #893

PR Type

What kind of change does this PR introduce?

  • Bugfix

Description

Right now setting Foreground or Background of the ToggleSwitch should be reflected in the switch.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Commits must be following the Conventional Commits specification
  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

Other information

with this changes setting Background and Foreground be reflected in the switch.

  1. Setting foreground: using this xaml the result is: <ToggleSwitch Header="On change Foreground" Foreground="Green" IsOn="True" />
    image

  2. Setting background: using this xaml the result is: <ToggleSwitch Header="On change Background" Background="Red" IsOn="True" />
    image

  3. Setting background and foreground: using this xaml the result is: <ToggleSwitch Header="On change Background and Foreground" Background="Red" Foreground="Red" IsOn="True" />
    image

Internal Issue (If applicable):

This is the issue

@agaldanaw2 agaldanaw2 changed the title MERGE Fix ToggleSwitch knob does not respect the Foreground property fix: ToggleSwitch knob does not respect the Foreground property Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Material][Android][iOS] ToggleSwitch knob does not respect the Foreground property
3 participants