Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Text File of Glyph Sources #16

Open
6 tasks
robloo opened this issue Sep 15, 2021 · 4 comments · May be fixed by #17
Open
6 tasks

Include Text File of Glyph Sources #16

robloo opened this issue Sep 15, 2021 · 4 comments · May be fixed by #17
Labels
kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification.

Comments

@robloo
Copy link

robloo commented Sep 15, 2021

What would you like to be added:

How was this font built? Was it done entirely manually in FontForge? Was a script used?

My intention is to obsolete this repository and generate a new, more maintainable symbols font :) However, it would save a lot of time if someone kept track of source glyphs. If they did, would be great to get an MIT licensed file I can process further.

Why is this needed:

Make glyph source/destination mapping clear and usable in other tooling.

For which Platform:

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renders for Xamarin.Forms
  • Windows
  • Build tasks

Anything else we need to know?

@robloo robloo added kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification. labels Sep 15, 2021
@davidjohnoliver davidjohnoliver linked a pull request Sep 16, 2021 that will close this issue
7 tasks
@davidjohnoliver
Copy link

#17 includes the hard info I was able to gather, including the Fluent System Icons assets used and the glyph positions they were mapped to. It also provides raw assets for the original icons that were created for glyphs that are used in the WinUI Fluent styles for which there was no equivalent in Fluent System Icons (at least at the time).

As to the question of how the font was created: it was indeed done manually with FontForge.

It seems that the WinJS Symbols font was used as a base. I'm not sure if this would've been the original, or if it was the version used by Uno.UI prior to Uno.Fonts, which would've had existing minor modifications. (If I had to guess, I would guess the latter.)

In addition, some icons were sourced from the Icons8 Line Awesome icon set (MIT license), but unfortunately no record was kept of which ones.

Finally there were a couple of adjustments made to fix visual issues with individual controls, going from the commit history.

@robloo
Copy link
Author

robloo commented Sep 16, 2021

It seems that the WinJS Symbols font was used as a base

No problem, that is already supported in my SymbolIconManager.

In addition, some icons were sourced from the Icons8 Line Awesome icon set (MIT license), but unfortunately no record was kept of which ones.

That shouldn't be an issue. I can add that as an IconSet source in the future.

Finally there were a couple of adjustments made to fix visual issues with individual controls, going from the commit history.

This is more problematic. I would hope their are better icons we can use now days that don't require tweaks. However, the mapping file format I am using here could be extended to support python commands to transform glyphs as needed. This should allow almost full customization on a per-glyph basis (move left/right, adjust width, etc.). That won't do anything if source SVG needs modification though. Custom icon sources could probably also be added to fix this.

@davidjohnoliver
Copy link

This is more problematic. I would hope their are better icons we can use now days that don't require tweaks. However, the mapping file format I am using here could be extended to support python commands to transform glyphs as needed. This should allow almost full customization on a per-glyph basis (move left/right, adjust width, etc.). That won't do anything if source SVG needs modification though. Custom icon sources could probably also be added to fix this.

From memory, it's not really about the icons being 'better' or 'worse' in a vacuum. There's a couple of cases where the glyph has to be pixel-perfect matched with Segoe or it looks 'off' - eg check marks in CheckBox. Custom icon sources can probably be a good way to go.

@robloo
Copy link
Author

robloo commented Sep 17, 2021

@davidjohnoliver Makes sense. If Uno is willing to donate the source SVG files under MIT I will pull them into a custom 'Undefined' icon set. It won't take long at all to support these. Matching will be done by fileName <-> iconName and mapping file format doesnt need to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants