Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguous Reference for C# Markup #1087

Closed
dansiegel opened this issue Apr 1, 2024 · 0 comments · Fixed by #1088
Closed

Ambiguous Reference for C# Markup #1087

dansiegel opened this issue Apr 1, 2024 · 0 comments · Fixed by #1088
Assignees
@kazo0
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.

Comments

@dansiegel
Copy link
Contributor

Current behavior

D:\a\1\s\UnoApp1\UnoApp1\Presentation\SecondPage.cs(8,25): error CS0104: 'Theme' is an ambiguous reference between 'Uno.Themes.Markup.Theme' and 'Uno.Toolkit.UI.Markup.Theme' [D:\a\1\s\UnoApp1\UnoApp1\UnoApp1.csproj::TargetFramework=net8.0]

https://dev.azure.com/uno-platform/Uno%20Platform/_build/results?buildId=118760&view=logs&jobId=6513cc34-25ea-5f83-b967-e7985fffc9d4&j=6513cc34-25ea-5f83-b967-e7985fffc9d4&t=49a18be8-7538-537b-8700-ad525c1a6f5a

Expected behavior

Uno.Toolkit.UI.Markup should NOT provide a class named Theme it should be unique such as ToolkitTheme to prevent an ambiguous Reference
@dansiegel dansiegel added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Apr 1, 2024
@dansiegel dansiegel mentioned this issue Apr 2, 2024
Merged
@kazo0 kazo0 mentioned this issue Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazo0 kazo0

Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore!: Rename Theme class to ToolkitTheme unoplatform/uno.toolkit.ui
2 participants
@dansiegel @kazo0