[WinUI] pressing enter when focused on TextBox with CommandExtensions.Command attached crash the app

[takla21]

Current behavior

Error thrown

Exception {"Element not found. (0x80070490)"}

Callstack

CommandExtensionsCrash.Windows.dll!CommandExtensionsCrash.App.InitializeComponent.AnonymousMethod__7_1(object sender = {CommandExtensionsCrash.App}, Microsoft.UI.Xaml.UnhandledExceptionEventArgs e = {Microsoft.UI.Xaml.UnhandledExceptionEventArgs}) Line 68
	at C:\p\CommandExtensionsCrash\CommandExtensionsCrash.Windows\obj\x86\Debug\net6.0-windows10.0.19041.0\win10-x86\App.g.i.cs(68)
Microsoft.WinUI.dll!WinRT._EventSource_global__Microsoft_UI_Xaml_UnhandledExceptionEventHandler.EventState.GetEventInvoke.AnonymousMethod__1_0(object sender, Microsoft.UI.Xaml.UnhandledExceptionEventArgs e)
Microsoft.WinUI.dll!ABI.Microsoft.UI.Xaml.UnhandledExceptionEventHandler.Do_Abi_Invoke(System.IntPtr thisPtr, System.IntPtr sender, System.IntPtr e)
[Native to Managed Transition]
[Managed to Native Transition]
Microsoft.WinUI.dll!ABI.Microsoft.UI.Xaml.IApplicationStaticsMethods.Start(WinRT.IObjectReference _obj, Microsoft.UI.Xaml.ApplicationInitializationCallback callback)
Microsoft.WinUI.dll!Microsoft.UI.Xaml.Application.Start(Microsoft.UI.Xaml.ApplicationInitializationCallback callback)
CommandExtensionsCrash.Windows.dll!CommandExtensionsCrash.Program.Main(string[] args = {string[0]}) Line 31
	at C:\p\CommandExtensionsCrash\CommandExtensionsCrash.Windows\obj\x86\Debug\net6.0-windows10.0.19041.0\win10-x86\App.g.i.cs(31)

Expected behavior

The command should be executed without crashing the app.

How to reproduce it (as minimally and precisely as possible)

• Download this sample CommandExtensionsCrash.zip
• Deploy on WinUI
• Make sure to focus on the textbox and press enter

Environment

Nuget Package: Uno.Toolkit.WinUI

Package Version(s): 2.5.0-dev.8

Affected platform(s):

• iOS
• Android
• WebAssembly
• WebAssembly renders for Xamarin.Forms
• Windows
• Build tasks

Visual Studio:

• 2022 (version: 17.4.3)
• 2019 (version: )
• for Mac (version: )

Relevant plugins:

• Resharper (version: )

Anything else we need to know?

[Xiaoy312]

fixed in #440 already

[jeromelaban]

@Xiaoy312 do we need to backport #440 ?

[takla21]

Hum the weird part is that I tested with the latest version available 2.5.0-dev.8. Although, the PR seems to have been merged yesterday. Maybe there are no build available with this fix yet.

[takla21]

The bug is indeed fix in 2.5.0-dev.10